v1.2.0-alpha.1 #1154
Merged
v1.2.0-alpha.1 #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
nguyer
requested review from
awrichar,
peterbroadhurst and
shorsher
as code owners
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 305 305
Lines 19966 19967 +1
=======================================
+ Hits 19964 19965 +1
Misses 1 1
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
awrichar
reviewed
Jan 20, 2023
| s.callbacks.OrderedCollectionNSEvent(database.CollectionPins, core.ChangeEventTypeCreated, pin.Namespace, pin.Sequence) | ||
| }, | ||
| ) | ||
| }, requestConflictEmptyResult) |
Contributor
There was a problem hiding this comment.
Do we log anything when the insert is a no-op? Seems good to at least be aware for debugging purposes.
awrichar
reviewed
Jan 20, 2023
| "image": "ghcr.io/hyperledger/firefly-fabconnect", | ||
| "tag": "v.0.9.16", | ||
| "sha": "4f4798ee34eee0b67886f1baa37f4d50a33e2932c94312f189fe5f015f6564a4" | ||
| "tag": "null-20230119-30", |
Contributor
Author
There was a problem hiding this comment.
Yeah interestingly enough that's the tag on the latest fabconnect image: https://github.com/hyperledger/firefly-fabconnect/pkgs/container/firefly-fabconnect/64423633?tag=null-20230119-30
It will get updated before this is released anyway.
awrichar
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
manifest.jsonwith the latest version of each dependency service, the latest CLI, the latest UI, and setsevmconnectto be the new default for E2E tests. Ethconnect is still tested, but it now takes a back seat compared to evmconnect.