Add identity manager and API input matrix logic #192

peterbroadhurst · 2021-09-15T05:41:23Z

Work in progress on https://github.com/hyperledger-labs/firefly/issues/187

Key proposals in this code so far - building with Unit Tests

New Identity Manager [Im] component
- This is not a plugin, instead a consistent component to do all identity mapping
- This would be expected to be where plugins would attach in the future
- Implementation includes testing of the various matrix options
- Implementation includes wiring this into Orchestrator
- Implementation includes changing imports on calling packages
- TODO (in this PR): Fix all the code that that currently calls Resolve on the now defunct Identity Interface
New fftypes.Identity sub-object
- Intended to replace single author field with author+key fields
- Pass pointer to this part of the struct to the new im.ResolveInputIdentity function
- TODO (in this PR): Embed this into all objects that can contain identity
Stubbing out the Identity Interface [Ii] plugin for now
- Still retained onchain key for config compatibility
- Removed all methods from interface
- Changed implementation to TBD for now in the code
Organizations and Nodes still use the signing identity
For now the intention is that Node.Owner and Organization.Identity remain the signing addresses
We should move these to be DIDs, but that will mean migration issues
Per https://github.com/hyperledger-labs/firefly/issues/187#issuecomment-919649333 we need to consider this before acting

The next step here is e2e testing, and working through various scenarios to test.
I have only done build+UT so far.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

codecov-commenter · 2021-09-16T02:07:12Z

Codecov Report

Merging #192 (22c7847) into main (9841abd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #192      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         201       202       +1     
  Lines       10974     11084     +110     
===========================================
+ Hits        10971     11084     +113     
+ Misses          2         0       -2     
+ Partials        1         0       -1

Impacted Files	Coverage Δ
pkg/fftypes/batch.go	`100.00% <ø> (ø)`
pkg/fftypes/message.go	`100.00% <ø> (ø)`
internal/assets/manager.go	`100.00% <100.00%> (ø)`
internal/batch/batch_manager.go	`100.00% <100.00%> (ø)`
internal/batch/batch_processor.go	`100.00% <100.00%> (ø)`
internal/batchpin/batchpin.go	`100.00% <100.00%> (ø)`
internal/blockchain/ethereum/ethereum.go	`100.00% <100.00%> (ø)`
internal/broadcast/datatype.go	`100.00% <100.00%> (ø)`
internal/broadcast/definition.go	`100.00% <100.00%> (ø)`
internal/broadcast/manager.go	`100.00% <100.00%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9841abd...22c7847. Read the comment docs.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>

nguyer · 2021-10-01T14:23:05Z

internal/syshandlers/syshandler_network_org.go

-	signingIdentity := org.Identity
-	if org.Parent != "" {
-		signingIdentity = org.Parent
-		parent, err := sh.database.GetOrganizationByIdentity(ctx, org.Parent)
-		if err != nil {
-			return false, err // We only return database errors
-		}
-		if parent == nil {
-			l.Warnf("Unable to process organization broadcast %s - parent identity not found: %s", msg.Header.ID, org.Parent)
-			return false, nil
-		}
-	}
-
-	id, err := sh.identity.Resolve(ctx, signingIdentity)
-	if err != nil {
-		l.Warnf("Unable to process organization broadcast %s - resolve identity failed: %s", msg.Header.ID, err)
-		return false, nil
-	}
-
-	if msg.Header.Author != id.OnChain {
-		l.Warnf("Unable to process organization broadcast %s - incorrect signature. Expected=%s Received=%s", msg.Header.ID, id.OnChain, msg.Header.Author)
-		return false, nil
-	}
-


@peterbroadhurst I'm not sure if this is right. This block of code was giving me trouble so I had it commented out for most of time while I was working on this PR. My gut tells me it shouldn't be removed though.

Yes, this check does need re-instating with a tweak. Doing that now

This is back now - checking that in the case of a child org:

The parent org is known

The transaction is signed by the parent org identity

awrichar · 2021-10-01T15:04:10Z

README.md

+  │       ├───┤ identity [Im] │  - Central identity management service across components
+  │       │   │ manager       │    * Resolves API input identity + key combos (short names, formatting etc.)
+  │       │   │               │    * Resolves registered on-chain signing keys back to identities
+  │       │   └───────────────┘    * Integrates with Blockchain Interface and plugable Identity Interface (TBD)


awrichar · 2021-10-01T15:05:12Z

db/migrations/sqlite/000027_create_key_fields.up.sql

@@ -0,0 +1,9 @@
+ALTER TABLE batches ADD COLUMN "key" VARCHAR(1024);
+UPDATE batches SET "key" = "";


There's no way to make this NOT NULL in sqlite due to the migration path, is there? 😞

Yeah, that's I conclusion I came to.

awrichar · 2021-10-01T15:10:34Z

test/e2e/e2e_test.go

+// 	<-received2
+// 	<-changes2 // also expect database change events
+// 	// TODO: validate created pool
+// }


k, seems this needs to be solved before merge

If it makes sense for me to be the one that does this, I'm happy to stick a commit on the end after other elements are stabilized.

awrichar · 2021-10-01T15:19:46Z

internal/identity/identitymanager.go

+	// Resolve the signing key
+	if inputKey != "" {
+		if cached := im.signingKeyCache.Get(inputKey); cached != nil {
+			cached.Extend(im.identityCacheTTL)


Is it necessary to manually Extend each time we fetch? Shouldn't this be handled transparently by the LRU cache?

I didn't find clear docs on this (the code you describe is elsewhere in FireFly).

Digging into the code here...
https://github.com/karlseguin/ccache/blob/ef4bd54683f611ad3df9ba84689234c78243c464/cache.go#L101-L117

Then here...
https://github.com/karlseguin/ccache/blob/ef4bd54683f611ad3df9ba84689234c78243c464/cache.go#L394-L410

It seems the behavior if you don't extend, is that it will end up in the purge list, for LRU deletion.
While Get alone will make it less likely to be the thing that's deleted, that's not the same as ensuring it's retained for a period after being explicitly accessed.

I guess my vote is to leave the pattern as it is for the moment in this PR, then consider a wrapper around the caching framework in a separate PR that handles optimization of the logic... based on some testing. Maybe that means removing use of expiry altogether? Or maybe only using expiry in the case of a cache miss (kind of as proposed here I think).

awrichar · 2021-10-01T15:38:45Z

internal/identity/identitymanager.go

+			cached.Extend(im.identityCacheTTL)
+			outputKey = cached.Value().(string)
+		} else {
+			outputKey, err = im.blockchain.ResolveSigningKey(ctx, inputKey)


I see that this resolution always goes to the blockchain plugin. In the context of tokens, I'm wondering how identities need to be expressed. For instance, as of #211, pool creation includes an operation to the token connector and an operation to the blockchain connector. It's not guaranteed that these connectors are talking to the same blockchain, so is it possible we'd need to resolve two keys via the two plugins? Maybe a question to ponder with @peterbroadhurst...

I do think this is incompletely thought through for Tokens in this PR.
My suggestion is to address the token specifics in #215

Yes, fine by me

awrichar · 2021-10-01T15:48:09Z

internal/assets/manager.go

-		pool.Author = config.GetString(config.OrgIdentity)
-	}
-	author, err := am.identity.Resolve(ctx, pool.Author)
+	err := am.identity.ResolveInputIdentity(ctx, &pool.Identity)


I noted this in the identity code below too, but feels like we're ultimately going to need to support 2 "author" identities here (1 for the token pool connector and 1 for the blockchain). They're likely to be the same in simple cases (ie Ethereum+ERC1155), but we'll need to allow them to be specified differently in the input payload if needed.

Agreed. Let's accept that this PR leaves things in a "still broken" state before+after for tokens, and address in #215 after merge.

awrichar · 2021-10-01T15:57:45Z

internal/tokens/https/https.go


-func (h *HTTPS) CreateTokenPool(ctx context.Context, identity *fftypes.Identity, pool *fftypes.TokenPool) error {
+func (h *HTTPS) CreateTokenPool(ctx context.Context, pool *fftypes.TokenPool) error {
 	data := createPoolData{


This is mostly a note to myself, but this is where the resolved key for the token connector needs to propagate into the REST call. Opened hyperledger/firefly-tokens-erc1155#30 to hopefully enable that to happen.

awrichar · 2021-10-01T18:34:44Z

internal/batchpin/batchpin.go

-		log.L(ctx).Errorf("Invalid signing identity '%s': %s", batch.Author, err)
-		return err
-	}
-


I guess it's now assumed that the identity has been pre-verified before invoking this helper?

Yes. It comes from the messages in the batch which must each have been resolved, and will be verified by all members processing the batch, so doing an additional pre-submission check here does not seem efficient.

awrichar · 2021-10-01T18:42:19Z

internal/syscore/syscore.go

+)
+
+// SystemCore specifies an interface for global utility functions, without creating a cycle between components
+type SystemCore interface {


I can't see where this is used...?

removed 👍

internal/networkmap/register_org.go

awrichar · 2021-10-01T18:52:40Z

internal/broadcast/message.go

 }

-func (bm *broadcastManager) BroadcastMessageWithID(ctx context.Context, ns string, id *fftypes.UUID, unresolved *fftypes.MessageInOut, resolved *fftypes.Message, waitConfirm bool) (out *fftypes.Message, err error) {
+func (bm *broadcastManager) BroadcastMessageWithResolvedID(ctx context.Context, ns string, in *fftypes.MessageInOut, waitConfirm bool) (out *fftypes.Message, err error) {


Can't find where this method is used...

Agreed, pulling it out. Think this became unnecessary in some of the updates @nguyer made

awrichar · 2021-10-01T19:06:24Z

internal/broadcast/message.go

 		resolved.Header.TxType = fftypes.TransactionTypeBatchPin
 	}

+	if !identityResolved {


Personally I don't like when bits of a method are enabled/disabled with a boolean flag - feels like it should just be a separate method that you invoke beforehand if you need it.

Side note, after this block executes, the identity is resolved, right? So it's odd that the boolean is propagated on line 75 & 86 rather than being flipped to true.

Think this is because the BroadcastRootOrgDefinition method was separated out, which is missing coverage.
Addressing this.

awrichar · 2021-10-01T19:08:54Z

internal/broadcast/message.go

+}
+
+// THIS IS WHERE THE NEW CODE FIRST CALLS ResolveInputIdentity
+// IT already has an author and key here


This comment feels like a note to the developer and maybe not something that should be committed... or at least it should be cleaned up before being committed.

awrichar · 2021-10-01T19:38:59Z

internal/events/aggregator.go

 	if len(nextPins) == 0 {
 		// If this is the first time we've seen the context, then this message is read as long as it is
-		// the first (nonce=0) message on the context, for one of the members, and there aren't any earlier
+		// the first (nonce=0) message onw the context, for one of the members, and there aren't any earlier


awrichar · 2021-10-01T19:41:29Z

internal/events/batch_pin_complete.go

 // We must block here long enough to get the payload from the publicstorage, persist the messages in the correct
 // sequence, and also persist all the data.
-func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, signingIdentity string, protocolTxID string, additionalInfo fftypes.JSONObject) error {
+func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, author string, protocolTxID string, additionalInfo fftypes.JSONObject) error {


For consistency in terminology, isn't this what we're calling a "key" (ie an Ethereum address)? Seems like the word "author" has evolved to mean a higher level FireFly/DID string.

Was transposed to signingIdentity below anyway, so using that consistently.

Think there might have been some earlier confusion that the pins table should contain resolved identities, whereas it is intentional that pins are just references to a pin received and validated that it matched the signing identity in the transaction object.

awrichar · 2021-10-01T19:58:08Z

internal/broadcast/definition.go

+}
+
+// THIS IS WHERE THE OLD CODE FIRST CALLS ResolveInputIdentity
+// It does NOT have an author and key the first time


This comment feels like it can be removed. Don't think there's any need to reference OLD CODE vs NEW CODE, but we should note if there's a specific contract coming into a method (ie the identity must/must not be resolved when calling this).

awrichar · 2021-10-01T20:04:59Z

internal/orchestrator/status.go


+	orgKey := config.GetString(config.OrgKey)
+	if orgKey == "" {
+		orgKey = config.GetString(config.OrgIdentityDeprecated)


Should we have a helper for getting the org key, which checks both the new and deprecated key? Seems like this pattern is repeated in a few places.

helper, mock, and test updates added

internal/privatemessaging/privatemessaging_test.go

awrichar · 2021-10-01T20:09:42Z

internal/privatemessaging/recipients.go

 	return node, nil
 }

 func (pm *privateMessaging) getReceipients(ctx context.Context, in *fftypes.MessageInOut) (gi *fftypes.GroupIdentity, err error) {


Not your change, but there's a typo in this method name.

awrichar · 2021-10-01T20:14:44Z

internal/events/persist_batch.go

 	if err != nil {
-		l.Errorf("Invalid batch '%s'. Author '%s' cound not be resolved: %s", batch.ID, batch.Author, err)
-		return false, nil // This is not retryable. skip this batch
+		return false, err


Did this become retryable?

No - will resolve this

awrichar · 2021-10-01T20:17:24Z

internal/events/persist_batch.go

 	return valid, err
 }

+func (em *eventManager) isRootOrgBroadcast(batch *fftypes.Batch) (bool, error) {


This feels...weird. Should we be tagging these messages in some special way? Unpacking all the data of every message in every batch to look for this special situation just feels very brute-force.

ok - think there's an issue in the code, where it should be doing this only in the case where we get an error verifying the identity.

ok - that's resolved now

internal/broadcast/definition.go

awrichar · 2021-10-01T20:26:07Z

internal/networkmap/register_node.go

-		node.Name = config.GetString(config.OrgIdentity)
+		orgName := config.GetString(config.OrgName)
+		if orgName != "" {
+			node.Name = fmt.Sprintf("%s.node", config.GetString(config.OrgName))


Can reuse orgName here instead of fetching again from config.

awrichar

I left a lot of comments, but they're mostly in the category of cleanup rather than functional changes.

I think the functionality looks good, although I'll confess it's difficult to follow exactly what the new rules are for when identities are resolved in each possible flow (some documentation to lay those down would be helpful). I'm relying largely on the E2E tests to assert that no major flows have been broken here =)

peterbroadhurst

Submitted PR for coverage and code duplication, continuing review.

peterbroadhurst · 2021-10-04T16:29:37Z

internal/batchpin/batchpin.go

-		log.L(ctx).Errorf("Invalid signing identity '%s': %s", batch.Author, err)
-		return err
-	}
-


Yes. It comes from the messages in the batch which must each have been resolved, and will be verified by all members processing the batch, so doing an additional pre-submission check here does not seem efficient.

peterbroadhurst · 2021-10-04T16:42:34Z

internal/broadcast/message.go

 }

-func (bm *broadcastManager) BroadcastMessageWithID(ctx context.Context, ns string, id *fftypes.UUID, unresolved *fftypes.MessageInOut, resolved *fftypes.Message, waitConfirm bool) (out *fftypes.Message, err error) {
+func (bm *broadcastManager) BroadcastMessageWithResolvedID(ctx context.Context, ns string, in *fftypes.MessageInOut, waitConfirm bool) (out *fftypes.Message, err error) {


Agreed, pulling it out. Think this became unnecessary in some of the updates @nguyer made

peterbroadhurst · 2021-10-04T16:47:39Z

internal/broadcast/message.go

 		resolved.Header.TxType = fftypes.TransactionTypeBatchPin
 	}

+	if !identityResolved {


Think this is because the BroadcastRootOrgDefinition method was separated out, which is missing coverage.
Addressing this.

peterbroadhurst

@awrichar - believe I've addressed all the comments now.

internal/broadcast/definition.go

peterbroadhurst · 2021-10-04T16:59:39Z

internal/events/batch_pin_complete.go

 // We must block here long enough to get the payload from the publicstorage, persist the messages in the correct
 // sequence, and also persist all the data.
-func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, signingIdentity string, protocolTxID string, additionalInfo fftypes.JSONObject) error {
+func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, author string, protocolTxID string, additionalInfo fftypes.JSONObject) error {


Was transposed to signingIdentity below anyway, so using that consistently.

peterbroadhurst · 2021-10-04T17:03:54Z

internal/events/batch_pin_complete.go

 // We must block here long enough to get the payload from the publicstorage, persist the messages in the correct
 // sequence, and also persist all the data.
-func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, signingIdentity string, protocolTxID string, additionalInfo fftypes.JSONObject) error {
+func (em *eventManager) BatchPinComplete(bi blockchain.Plugin, batchPin *blockchain.BatchPin, author string, protocolTxID string, additionalInfo fftypes.JSONObject) error {


Think there might have been some earlier confusion that the pins table should contain resolved identities, whereas it is intentional that pins are just references to a pin received and validated that it matched the signing identity in the transaction object.

peterbroadhurst · 2021-10-04T17:09:37Z

internal/events/persist_batch.go

 	if err != nil {
-		l.Errorf("Invalid batch '%s'. Author '%s' cound not be resolved: %s", batch.ID, batch.Author, err)
-		return false, nil // This is not retryable. skip this batch
+		return false, err


No - will resolve this

peterbroadhurst · 2021-10-04T17:11:11Z

internal/events/persist_batch.go

-	if author != id.OnChain {
-		l.Errorf("Invalid batch '%s'. Author '%s' does not match transaction submitter '%s'", batch.ID, id.OnChain, author)
+
+	isRootOrgBroadcast, err := em.isRootOrgBroadcast(batch)


There is no error return from this function, removing.

peterbroadhurst · 2021-10-04T17:54:57Z

internal/events/persist_batch.go

 	return valid, err
 }

+func (em *eventManager) isRootOrgBroadcast(batch *fftypes.Batch) (bool, error) {


ok - that's resolved now

peterbroadhurst · 2021-10-04T18:04:32Z

internal/orchestrator/status.go


+	orgKey := config.GetString(config.OrgKey)
+	if orgKey == "" {
+		orgKey = config.GetString(config.OrgIdentityDeprecated)


helper, mock, and test updates added

internal/privatemessaging/privatemessaging_test.go

peterbroadhurst · 2021-10-04T18:08:04Z

internal/privatemessaging/recipients.go

 	return node, nil
 }

 func (pm *privateMessaging) getReceipients(ctx context.Context, in *fftypes.MessageInOut) (gi *fftypes.GroupIdentity, err error) {


peterbroadhurst · 2021-10-04T18:09:41Z

internal/syscore/syscore.go

+)
+
+// SystemCore specifies an interface for global utility functions, without creating a cycle between components
+type SystemCore interface {


removed 👍

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>

As of now, token operations will not include any identity mapping - overriding any identities for token operations will require passing a string that is understood by the underlying connector (ie an Ethereum address). For convenience, this defaults to the identity of the local org. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>

codecov-commenter · 2021-10-05T21:01:18Z

Codecov Report

Merging #192 (0880ed5) into main (f435cbf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0880ed5 differs from pull request most recent head 6f62a4a. Consider uploading reports for the commit 6f62a4a to get more accurate results

@@            Coverage Diff             @@
##              main      #192    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          206       207     +1     
  Lines        11163     11318   +155     
==========================================
+ Hits         11163     11318   +155

Impacted Files	Coverage Δ
pkg/fftypes/batch.go	`100.00% <ø> (ø)`
pkg/fftypes/message.go	`100.00% <ø> (ø)`
pkg/fftypes/tokenpool.go	`100.00% <ø> (ø)`
pkg/wsclient/wstestserver.go	`100.00% <ø> (ø)`
internal/assets/manager.go	`100.00% <100.00%> (ø)`
internal/assets/token_pool_created.go	`100.00% <100.00%> (ø)`
internal/batch/batch_manager.go	`100.00% <100.00%> (ø)`
internal/batch/batch_processor.go	`100.00% <100.00%> (ø)`
internal/batchpin/batchpin.go	`100.00% <100.00%> (ø)`
internal/blockchain/ethereum/config.go	`100.00% <100.00%> (ø)`
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f435cbf...6f62a4a. Read the comment docs.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>

jimthematrix · 2021-10-01T16:23:40Z

pkg/fftypes/identity.go

 type Identity struct {
-	Identifier string `json:"identifier,omitempty"`
-	OnChain    string `json:"onchain,omitempty"`
+	Author string `json:"author,omitempty"`


feels like Identifier would be a better name here, since the identity is used in more scenarios than sending/broadcasting messages, such as an org's Identity that's solely used to endorse other identities

never mind this one, was from an earlier thought (days ago) that has since been discarded, but neglected to delete the comment

jimthematrix · 2021-10-06T19:45:08Z

db/migrations/postgres/000030_create_key_fields.up.sql

+BEGIN;
+
+ALTER TABLE batches ADD "key" VARCHAR(1024);
+UPDATE batches SET "key" = "";


the empty string should be delimited by single quotes instead of double quotes, otherwise you'd get the following error during startup:

FF10163: Database migration failed: FF10163: Database migration failed: migration failed: zero-length delimited identifier at or near """" (column 28) in line 4: BEGIN; ALTER TABLE batches ADD "key" VARCHAR(1024); UPDATE batches SET "key" = ""; ALTER TABLE batches ALTER COLUMN "key" SET NOT NULL; ALTER TABLE messages ADD "key" VARCHAR(1024); UPDATE messages SET "key" = ""; ALTER TABLE messages ALTER COLUMN "key" SET NOT NULL; ALTER TABLE tokenpool ADD "key" VARCHAR(1024); UPDATE tokenpool SET "key" = ""; ALTER TABLE tokenpool ALTER COLUMN "key" SET NOT NULL;

jimthematrix · 2021-10-06T19:45:31Z

db/migrations/sqlite/000030_create_key_fields.up.sql

@@ -0,0 +1,8 @@
+ALTER TABLE batches ADD COLUMN "key" VARCHAR(1024);
+UPDATE batches SET "key" = "";


same as above, single quotes instead of double quotes

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>

Add identity manager and API input matrix logic

ca42a24

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

peterbroadhurst requested review from awrichar, jimthematrix and nguyer September 15, 2021 05:41

peterbroadhurst added 3 commits September 15, 2021 16:47

Add additional resolvers to identity manager

cce35d7

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Resolve identity on broadcast send

89864e7

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Work through UTs across all components

22c7847

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

peterbroadhurst mentioned this pull request Sep 20, 2021

Identity and signing key - architectural update #187

Closed

nguyer added 3 commits September 27, 2021 15:50

Update registration to use new identity code

10d7ab3

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>

Fix private messaging with new identities

0d369c1

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>

Fix unit tests and E2E tests

e5f7819

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>

nguyer reviewed Oct 1, 2021

View reviewed changes

awrichar mentioned this pull request Oct 1, 2021

Add support for mint, burn, and transfer #215

Merged

awrichar reviewed Oct 1, 2021

View reviewed changes

internal/networkmap/register_org.go Show resolved Hide resolved

awrichar reviewed Oct 1, 2021

View reviewed changes

internal/privatemessaging/privatemessaging_test.go Show resolved Hide resolved

awrichar reviewed Oct 1, 2021

View reviewed changes

internal/broadcast/definition.go Show resolved Hide resolved

awrichar reviewed Oct 1, 2021

View reviewed changes

peterbroadhurst commented Oct 4, 2021

View reviewed changes

peterbroadhurst force-pushed the identity branch from 87061f7 to 5574f2d Compare October 4, 2021 18:18

peterbroadhurst commented Oct 4, 2021

View reviewed changes

peterbroadhurst marked this pull request as ready for review October 4, 2021 18:20

peterbroadhurst requested a review from nickgaski as a code owner October 4, 2021 18:20

Address review comments (re-push after DCO issues)

5a51d6b

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

peterbroadhurst force-pushed the identity branch from 5574f2d to 5a51d6b Compare October 4, 2021 18:28

peterbroadhurst and others added 4 commits October 4, 2021 14:49

Do the hyperledger-labs to hyperledger rework in branch to help merge

6a51881

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Merge branch 'main' of github.com:hyperledger/firefly into HEAD

5d783c7

Fix persist_batch test

631fb31

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>

peterbroadhurst and others added 3 commits October 6, 2021 15:04

Validate parent org

9589c03

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Restore coverage blip due to message type change

6f1aaea

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Resolve local org DID when fetching

bee2f7a

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>

awrichar approved these changes Oct 6, 2021

View reviewed changes

jimthematrix suggested changes Oct 6, 2021

View reviewed changes

Fixed empty string delimiter in SQL migration scripts

6f62a4a

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>

jimthematrix approved these changes Oct 6, 2021

View reviewed changes

jimthematrix merged commit 06dedc5 into hyperledger:main Oct 6, 2021

jimthematrix deleted the identity branch October 6, 2021 21:55

jimthematrix mentioned this pull request Oct 8, 2021

Fabric plugin #184

Merged

		@@ -0,0 +1,9 @@
		ALTER TABLE batches ADD COLUMN "key" VARCHAR(1024);
		UPDATE batches SET "key" = "";

		@@ -0,0 +1,8 @@
		ALTER TABLE batches ADD COLUMN "key" VARCHAR(1024);
		UPDATE batches SET "key" = "";

Add identity manager and API input matrix logic #192

Add identity manager and API input matrix logic #192

Uh oh!

Conversation

peterbroadhurst commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Sep 16, 2021

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterbroadhurst Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

awrichar Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

peterbroadhurst commented Sep 15, 2021 •

edited

Loading

peterbroadhurst Oct 4, 2021 •

edited

Loading

awrichar Oct 1, 2021 •

edited

Loading

awrichar left a comment •

edited

Loading