Skip to content

Conversation

@nguyer
Copy link
Contributor

@nguyer nguyer commented Oct 11, 2021

It looks like there's a lot of code change here, but it's really not a lot. To summarize the changes:

  • Existing E2E tests have been split up into two test suites:
    • OnChainOffChainTestSuite
    • TokensTestSuite
  • There are two "traditional tests" that run these suites
    • TestEthereumE2ESuite which runs both suites
    • TestFabricE2ESuite which just runs OnChainOffChainTestSuite
  • The run.sh test script has been updated to use several new environment variables which get passed to the CLI to create the appropriate environment.
  • The E2E GitHub action now uses a matrix strategy to run each variant of the tests while setting the appropriate environment variables.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer marked this pull request as ready for review October 21, 2021 14:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #242 (c1d9804) into main (818b5ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #242   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          225       225           
  Lines        12406     12417   +11     
=========================================
+ Hits         12406     12417   +11     
Impacted Files Coverage Δ
pkg/fftypes/tokenaccount.go 100.00% <0.00%> (ø)
internal/assets/token_pool.go 100.00% <0.00%> (ø)
internal/assets/token_transfer.go 100.00% <0.00%> (ø)
internal/assets/token_pool_created.go 100.00% <0.00%> (ø)
internal/events/tokens_transferred.go 100.00% <0.00%> (ø)
internal/database/sqlcommon/tokenaccount_sql.go 100.00% <0.00%> (ø)
internal/database/sqlcommon/tokentransfer_sql.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818b5ed...c1d9804. Read the comment docs.

@nguyer
Copy link
Contributor Author

nguyer commented Oct 22, 2021

Need to get the CLI changes merged to create a Fabric network before the Fabric E2E tests will pass

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer merged commit db94b5e into main Oct 27, 2021
@nguyer nguyer deleted the e2e-matrix branch October 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants