Fix logic for transfer+message with waitConfirm=true #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Make the flows and method naming in these packages as similar as possible, and attempt to clarify the branches that result in an early send (within the DB transaction) vs a deferred send. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Introduce new types for Broadcast and PrivateMessage, which can track state information as a message is resolved and sent. Currently we have two types of "send" (Send or SendAndWait), but this will also allow future customizations to the send flow. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Ensure the pieces are sent in the correct order and wait for both to be confirmed. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
========================================
Coverage 99.53% 99.53%
========================================
Files 217 217
Lines 12245 12345 +100
========================================
+ Hits 12188 12288 +100
Misses 42 42
Partials 15 15
Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Oct 20, 2021
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
This is great @awrichar - really cleans things up, and adds a valuable extra layer of structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #218.
Includes a new MessageSender interface that is used by asset manager, broadcast manager, private messaging,
and sync-async bridge. This allows cleaner tracking of the progress of resolving and sending a message, and
injection of hooks at particular spots in the flow (which is needed here to dispatch the transfer and message in
a specific order).