Skip to content

Group token database calls into RunAsGroup wherever possible #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

Group token database calls into RunAsGroup wherever possible #273

merged 2 commits into from
Oct 25, 2021

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Oct 20, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #273 (dacd36b) into main (6790519) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       223           
  Lines        12376     12380    +4     
=========================================
+ Hits         12376     12380    +4
Impacted Files Coverage Δ
internal/assets/token_pool.go 100.00% <100.00%> (ø)
internal/assets/token_pool_created.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6790519...dacd36b. Read the comment docs.

@awrichar awrichar mentioned this pull request Oct 20, 2021
Closed
@awrichar
Minor cleanup of token pool methods
18f7f86 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Group token database calls into RunAsGroup wherever possible
dacd36b 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
nguyer
nguyer approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@awrichar awrichar merged commit 70d1022 into hyperledger:main Oct 25, 2021
@awrichar awrichar deleted the group branch October 25, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbroadhurst peterbroadhurst Awaiting requested review from peterbroadhurst

1 more reviewer

@nguyer nguyer nguyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awrichar @codecov-commenter @nguyer