Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

The intention of the topics field, is that you can create a stream of data that is grouped on a particular ordered business context, and the tag sub-classifies messages within that.

This means that querying by topic and tag is a primary use case, for which index(es) should exist.

This PR proposes a single combined index, on topic then tag, as I believe that's the most likely combination of filter across use cases.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #290 (84a3a97) into main (70d1022) will not change coverage.
The diff coverage is n/a.

❗ Current head 84a3a97 differs from pull request most recent head 545eae5. Consider uploading reports for the commit 545eae5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          225       225           
  Lines        12410     12410           
=========================================
  Hits         12410     12410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d1022...545eae5. Read the comment docs.

@nguyer nguyer merged commit 856425e into hyperledger:main Oct 26, 2021
@nguyer nguyer deleted the tagindex branch October 26, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants