Add check before writing to websocket channel #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
awrichar
approved these changes
Oct 28, 2021
Contributor
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Seems fine. Happy to put this in and see if it helps things.
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Contributor
|
Didn't work 🙁 I'm still seeing the panic on writing to a closed channel. |
peterbroadhurst
added a commit
to kaleido-io/firefly
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
added a commit
that referenced
this pull request
Jan 21, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
pushed a commit
that referenced
this pull request
Jan 21, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
pushed a commit
that referenced
this pull request
Jan 21, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix #265
I'm not 100% sure my unit test accurately reproduces the exact situation we're running into in that issue though. Adding the extra check does indeed make this test pass. However, I'm not sure we can count on
ws.closedto be set correctly 100% of the time before writing to the channel.