Skip to content

Add ?fetchdata on messages collection to include data, and make consistent with get by ID #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add ?fetchdata on messages collection to include data, and make consistent with get by ID #299

merged 1 commit into from
Oct 28, 2021

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Oct 27, 2021

  • Deprecates existing data query param on /messages/:id
  • Adds consistent fetchdata query param on both /messages and /messages/:id
  • Bit of restructuring in line with recent directions on code style around use of bool params

@peterbroadhurst
Add fetchdata to message/messages and dep ?data on msg
f58920f 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
nguyer approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nguyer nguyer merged commit 368beaf into hyperledger:main Oct 28, 2021
@nguyer nguyer deleted the data branch October 28, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awrichar awrichar Awaiting requested review from awrichar

@nickgaski nickgaski Awaiting requested review from nickgaski

1 more reviewer

@nguyer nguyer nguyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterbroadhurst @nguyer