Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Oct 28, 2021

To maintain consistency amongst /tokens routes, the following endpoints are needed:
POST /namespaces/{ns}/tokens/mint
POST /namespaces/{ns}/tokens/burn
POST /namespaces/{ns}/tokens/transfers
POST /namespaces/{ns}/tokens/pools

David Echelberger added 4 commits October 27, 2021 18:15
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #307 (12948a1) into main (04cd718) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 12948a1 differs from pull request most recent head 82f3d58. Consider uploading reports for the commit 82f3d58 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              main      #307    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          224       227     +3     
  Lines        12387     12505   +118     
==========================================
+ Hits         12387     12505   +118     
Impacted Files Coverage Δ
internal/assets/manager.go 100.00% <ø> (ø)
internal/apiserver/route_post_token_burn.go 100.00% <100.00%> (ø)
...nternal/apiserver/route_post_token_burn_by_type.go 100.00% <100.00%> (ø)
internal/apiserver/route_post_token_mint.go 100.00% <100.00%> (ø)
...nternal/apiserver/route_post_token_mint_by_type.go 100.00% <100.00%> (ø)
internal/apiserver/route_post_token_transfer.go 100.00% <100.00%> (ø)
...nal/apiserver/route_post_token_transfer_by_type.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cd718...82f3d58. Read the comment docs.

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
David Echelberger added 3 commits October 29, 2021 10:10
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@dechdev dechdev changed the title POST /tokens/<mint | burn | transfers> POST /tokens/<mint | burn | transfers | pools> Oct 29, 2021
@awrichar
Copy link
Contributor

E2E failure looks like #308

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@awrichar awrichar merged commit 2bd7e2b into hyperledger:main Nov 1, 2021
@awrichar awrichar deleted the post-tokens branch November 1, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants