Skip to content

Conversation

@shorsher
Copy link
Member

Adds BatchPinCounter prometheus metric, which will be incremented each time a batchpin is submitted

@codecov-commenter
Copy link

Codecov Report

Merging #334 (fa6bb94) into main (6761542) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #334   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          232       232           
  Lines        12721     12724    +3     
=========================================
+ Hits         12721     12724    +3     
Impacted Files Coverage Δ
internal/apiserver/server.go 100.00% <100.00%> (ø)
internal/batchpin/batchpin.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6761542...fa6bb94. Read the comment docs.

Copy link
Contributor

@onelapahead onelapahead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the first metric! Thank you for getting this going @shorsher.

Next PR I think we can then start experimenting with metric labels and using histograms to time the total duration of batchpins across the DB and blockchain interactions.

For those interested, here are some good resources for learning more about Prometheus metric types and when to use histograms specifically (TL;DR pretty much always use them instead of summaries if you want to aggregate across multiple processes / pods):

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@nguyer nguyer merged commit 29fe427 into hyperledger:main Nov 23, 2021
@nguyer nguyer deleted the prom-batchpin branch November 23, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants