Skip to content

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Nov 22, 2021

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #335 (1c7f6bf) into main (c2ebba4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1c7f6bf differs from pull request most recent head 04a349a. Consider uploading reports for the commit 04a349a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          232       232           
  Lines        12717     12728   +11     
=========================================
+ Hits         12717     12728   +11     
Impacted Files Coverage Δ
internal/apiserver/route_post_token_burn.go 100.00% <ø> (ø)
...nternal/apiserver/route_post_token_burn_by_type.go 100.00% <ø> (ø)
internal/apiserver/route_post_token_mint.go 100.00% <ø> (ø)
...nternal/apiserver/route_post_token_mint_by_type.go 100.00% <ø> (ø)
internal/apiserver/route_post_token_transfer.go 100.00% <ø> (ø)
...nal/apiserver/route_post_token_transfer_by_type.go 100.00% <ø> (ø)
pkg/fftypes/tokenbalance.go 100.00% <ø> (ø)
internal/apiserver/server.go 100.00% <100.00%> (ø)
internal/batchpin/batchpin.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/tokenbalance_sql.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ebba4...04a349a. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Will leave you to do the manifestgen.sh head once the tokens PR is merged, and built (one small comment left on that one).

@awrichar awrichar merged commit 4245b61 into hyperledger:main Nov 24, 2021
@awrichar awrichar deleted the token-uri branch November 24, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting a URI for NFTs

4 participants