-
Notifications
You must be signed in to change notification settings - Fork 242
Metrics endpoint to support charting #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 234 237 +3
Lines 12796 12896 +100
==========================================
+ Hits 12796 12896 +100
Continue to review full report at Codecov.
|
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
awrichar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Noted one small change inline on error messages.
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
In order to support histograms, pie charts, and other charting in Firefly-UI, an endpoint is needed to fetch an array of row counts in a table, where each index (bucket) of the array is the count for the corresponding time interval between the start and end time.
time interval =
startTime - endTime/bucketsGET
/api/v1/namespaces/default/metricswith the following params:startTime: unix time stamp to specify the start time of the data you want to fetch (ex. 1638279785)endTime: unix time stamp to specify the end time of the data you want to fetch (ex. 1638366185)buckets: number of buckets to divide the data into between the start and end timetype: the table name of the data you want to fetch data forTypical response times for this endpoint are
50-100ms. Thebucketsparam is hard capped at 100 buckets to prevent expensive queries to the DB