Skip to content

Conversation

@onelapahead
Copy link
Contributor

We aren't ensuring there's some sort of writeable filesystem to the DX pods for blob storage, might as well offer the ability to persist it too. This refactors how we template the DX PVCs to other more customization (size, storage class, etc.) for future users, as well as offers the ability to disable the PVCs and use emptyDir instead.

NOTE: This does include a breaking change in the chart for how DX data is handled: /data/peers and /data/peer-certs are now apart of the same PVC but given subdirs within the volume. However, we have not made an official release of the chart yet.

Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #354 (26b9b48) into main (002e6f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          237       237           
  Lines        12858     12858           
=========================================
  Hits         12858     12858           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002e6f7...26b9b48. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧊
💧

@peterbroadhurst peterbroadhurst merged commit 0eae821 into hyperledger:main Dec 20, 2021
@peterbroadhurst peterbroadhurst deleted the helm-dx-blobstorage branch December 20, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants