[helm] Publishing Helm Chart to GHCR via OCI #359
Conversation
Codecov Report
@@ Coverage Diff @@
## main #359 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 12886 12886
=========================================
Hits 12886 12886 Continue to review full report at Codecov.
|
onelapahead
force-pushed
the
helm-oci-chart-publishing
branch
from
434b617 to
f427940
Compare
Signed-off-by: hfuss <haydenfuss@gmail.com>
…support for older ingressses Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
…ereum Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
Signed-off-by: hfuss <haydenfuss@gmail.com>
onelapahead
force-pushed
the
helm-oci-chart-publishing
branch
from
dc1a15b to
4c078fd
Compare
Signed-off-by: hfuss <haydenfuss@gmail.com>
onelapahead
changed the title
onelapahead
requested review from
awrichar,
nguyer and
nickgaski
as code owners
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Filter Helm Releases |
There was a problem hiding this comment.
Will want @nguyer's input on this. This assumes we might make separate GH releases for the chart itself, and so we needed a way to prevent the Docker image from being re-published if that was done.
There was a problem hiding this comment.
Hayden and I chatted about this. I'm fine with this being in the GitHub Action for now, but I think I'd like to have further discussion about creating "Releases" in GitHub for the Helm chart. I'm not convinced that we want releases for multiple different things on the GitHub release page just yet.
drewmarshburn
left a comment
drewmarshburn
left a comment
There was a problem hiding this comment.
Looks good to me! Love the detailed README, was super helpful and I think it'll really help get adoption.
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Filter Helm Releases |
There was a problem hiding this comment.
Hayden and I chatted about this. I'm fine with this being in the GitHub Action for now, but I think I'd like to have further discussion about creating "Releases" in GitHub for the Helm chart. I'm not convinced that we want releases for multiple different things on the GitHub release page just yet.
4 participants
Closes #271.
Helm offers the ability to publish and download charts via OCI registries AKA docker images.
This PR modifies the existing Helm workflow to publishes the latest chart version to GHCR underneath the
ghcr.io/hyperledger/helm/fireflypackage (vs. the FireFly docker image being published underghcr.io/hyperledger/firefly.) whenever there is a merge tomainthat changes either the chart files or workflow.If a tag / GH release is made prefixed w/
helm-v*, and it matches the chart's current version, then an official semver release is published to GHCR.Lastly, this includes some minor changes to the values, has the chart use the latest FireFly release, and overhauls the chart README so that folks can get started using the chart. See https://github.com/kaleido-io/firefly/tree/helm-oci-chart-publishing/deploy/charts/firefly for a preview of the README. The format of the chart README is inspired by other community charts like https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack and https://github.com/kubernetes/ingress-nginx/tree/main/charts/ingress-nginx.