-
Notifications
You must be signed in to change notification settings - Fork 242
Add Performance Testing Details to README #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eberger727 - I wonder if it makes sense to make the FireFly readme section just link to the Performance CLI (like it does for other components), and for the architecture for the performance CLI to go into the README of that tool?
|
e.g. just update this section: https://github.com/hyperledger/firefly#git-repositories |
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
I'm going to close and re-open this to try to get the build to pass now that we fixed the linting issue. |
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 12886 12920 +34
=========================================
+ Hits 12886 12920 +34
Continue to review full report at Codecov.
|
Adding performance testing details to README