Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Jan 3, 2022

Adding performance testing details to README

David Echelberger added 2 commits January 3, 2022 11:21
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eberger727 - I wonder if it makes sense to make the FireFly readme section just link to the Performance CLI (like it does for other components), and for the architecture for the performance CLI to go into the README of that tool?

@peterbroadhurst
Copy link
Contributor

e.g. just update this section: https://github.com/hyperledger/firefly#git-repositories

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nguyer
Copy link
Contributor

nguyer commented Jan 7, 2022

I'm going to close and re-open this to try to get the build to pass now that we fixed the linting issue.

@nguyer nguyer closed this Jan 7, 2022
@nguyer nguyer reopened this Jan 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #373 (18ead0e) into main (e603455) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #373   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines        12886     12920   +34     
=========================================
+ Hits         12886     12920   +34     
Impacted Files Coverage Δ
pkg/fftypes/data.go 100.00% <0.00%> (ø)
pkg/fftypes/byteable.go 100.00% <0.00%> (ø)
pkg/wsclient/wsclient.go 100.00% <0.00%> (ø)
internal/data/blobstore.go 100.00% <0.00%> (ø)
internal/apiserver/server.go 100.00% <0.00%> (ø)
internal/events/dx_callbacks.go 100.00% <0.00%> (ø)
internal/database/postgres/config.go 100.00% <0.00%> (ø)
internal/database/sqlcommon/blob_sql.go 100.00% <0.00%> (ø)
internal/database/sqlcommon/data_sql.go 100.00% <0.00%> (ø)
internal/dataexchange/dxhttps/dxhttps.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e603455...18ead0e. Read the comment docs.

@nguyer nguyer merged commit 8cfd4b4 into hyperledger:main Jan 7, 2022
@nguyer nguyer deleted the perf-readme branch January 7, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants