FIR-4 (rich query updates) and FIR-7 (DX manifests) integration to onchain-logic branch #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
requested review from
awrichar,
nguyer and
nickgaski
as code owners
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
changed the title
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Contributor
Author
Contributor
Author
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Contributor
Author
|
I've also restored coverage on a couple of packages that dropped |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
awrichar
reviewed
Jan 12, 2022
| hash CHAR(64) NOT NULL, | ||
| created BIGINT NOT NULL, | ||
| value BYTEA NOT NULL, | ||
| value TEXT NOT NULL, |
Contributor
There was a problem hiding this comment.
nit: the NOT NULL on every column is now misaligned 😱
Contributor
Author
There was a problem hiding this comment.
ok, fixed
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
reviewed
Jan 13, 2022
awrichar
reviewed
Jan 13, 2022
awrichar
reviewed
Jan 13, 2022
awrichar
reviewed
Jan 13, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
reviewed
Jan 13, 2022
internal/events/dx_callbacks_test.go
Outdated
| ID: id, | ||
| BackendID: "tracking12345", | ||
| Input: fftypes.JSONObject{ | ||
| "maniest": "Bob", |
awrichar
approved these changes
Jan 13, 2022
Contributor
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Looks good to me! Only minor things noted - I don't see any functional issues.
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivery PR for this FIRs into the
onchain-logicnext-release branch: