Fix token account listing on Postgres #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres has much stricter constraints on DISTINCT/GROUP BY queries - specifically, the fields used in ORDER BY must also be part of SELECT, and therefore may need an aggregate function applied in order to give deterministic results. Implement ordering by "seq" or "updated", which seem like the most useful. Resolves hyperledger#416 Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 277 277
Lines 14858 14860 +2
=========================================
+ Hits 14858 14860 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres has much stricter constraints on DISTINCT/GROUP BY queries - specifically,
the fields used in ORDER BY must also be part of SELECT, and therefore may need
an aggregate function applied in order to give deterministic results.
Implement ordering by "seq" or "updated", which seem like the most useful.
Resolves #416