Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

Fixes the core symptom reported in #421

Note that this does not implement the full change to batches described in the discussion on that issue.
However, when that change happens, this fix will still be applicable.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@awrichar
Copy link
Contributor

Could also call it simply "ReplaceMessage" - will leave it up to you if you prefer the current name though.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #438 (3a32ae6) into main (afb4c84) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          277       277           
  Lines        14939     14955   +16     
=========================================
+ Hits         14939     14955   +16     
Impacted Files Coverage Δ
internal/database/sqlcommon/message_sql.go 100.00% <100.00%> (ø)
internal/events/tokens_transferred.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb4c84...3a32ae6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants