Skip to content

Conversation

@awrichar
Copy link
Contributor

Also move the query helpers from Contract Manager to Orchestrator, as this
has become a generic construct that spans more than one manager/plugin.

Also move the query helpers from Contract Manager to Orchestrator, as this
has become a generic construct that spans more than one manager/plugin.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #443 (4b78cb9) into main (32bad71) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          278       278           
  Lines        14952     14952           
=========================================
  Hits         14952     14952           
Impacted Files Coverage Δ
internal/contracts/manager.go 100.00% <ø> (ø)
internal/orchestrator/orchestrator.go 100.00% <ø> (ø)
...rnal/apiserver/route_get_blockchain_event_by_id.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_blockchain_events.go 100.00% <100.00%> (ø)
internal/orchestrator/data_query.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bad71...4b78cb9. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 ⛓️

@peterbroadhurst
Copy link
Contributor

Some e2e changes still needed before merge:

2022-01-24T23:02:32.8167161Z     restclient.go:75: Headers: map[Content-Length:[31] Content-Type:[application/json application/json] Date:[Mon, 24 Jan 2022 23:02:32 GMT] Vary:[Origin]]
2022-01-24T23:02:32.8167559Z     restclient.go:625: 
2022-01-24T23:02:32.8168020Z         	Error Trace:	restclient.go:625
2022-01-24T23:02:32.8168782Z         	            				e2e_test.go:332
2022-01-24T23:02:32.8169477Z         	            				ethereum_contract_test.go:329
2022-01-24T23:02:32.8169781Z         	Error:      	Not equal: 
2022-01-24T23:02:32.8170259Z         	            	expected: 200
2022-01-24T23:02:32.8170603Z         	            	actual  : 404
2022-01-24T23:02:32.8170992Z         	Test:       	TestEthereumE2ESuite/TestFFIInvokeMethod
2022-01-24T23:02:32.8171988Z         	Messages:   	GET /namespaces/default/contracts/events/ee78af00-43a9-459e-b96c-c82af11b9744 [404]: {"error":"FF10109: Not found"}
2022-01-24T23:02:32.8172649Z     e2e_test.go:259: Websocket 127.0.0.1:5000 closing, error: read tcp 127.0.0.1:51528->127.0.0.1:5000: use of closed network connection

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit 4bc6c91 into hyperledger:main Jan 25, 2022
@awrichar awrichar deleted the blockchainevents branch January 25, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants