Skip to content

Set default keepalive timeout to 5s on clients for Node.js connectors #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Set default keepalive timeout to 5s on clients for Node.js connectors #470

merged 1 commit into from
Feb 4, 2022

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Feb 3, 2022

Fix for #468

For keepalive timeout there's a big disparity between Go and Node.js

@peterbroadhurst
Set default keepalive timeout to 5s on clients for Node.js connectors
c710ddf 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst merged commit 07ae280 into hyperledger:main Feb 4, 2022
@peterbroadhurst peterbroadhurst deleted the idle-timeout-5s branch February 4, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awrichar awrichar awrichar approved these changes

@nguyer nguyer Awaiting requested review from nguyer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterbroadhurst @awrichar