Make the factories act like factories #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of instantiating all plugins up front, instantiate them on demand. Fixes hyperledger#467 Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Contributor
Author
|
Looks like the events factory actually does want singletons and not a true factory... |
It appears that this factory actually relies on the singleton behavior. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 266 266
Lines 15134 15134
=======================================
Hits 15123 15123
Misses 11 11 Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Feb 4, 2022
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
This makes sense. I feel like we could at some point spend some more cycles to make it feel cleaner, but I don't think it justifies further distraction now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of instantiating all plugins up front, instantiate them on demand.
Fixes #467