Skip to content

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Feb 3, 2022

Follow-up to #462

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #475 (dab9901) into main (a3992b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         266      266           
  Lines       15134    15142    +8     
=======================================
+ Hits        15123    15131    +8     
  Misses         11       11           
Impacted Files Coverage Δ
internal/definitions/definition_handler.go 100.00% <100.00%> (ø)
...ternal/definitions/definition_handler_contracts.go 100.00% <100.00%> (ø)
...nternal/definitions/definition_handler_datatype.go 100.00% <100.00%> (ø)
...ternal/definitions/definition_handler_namespace.go 100.00% <100.00%> (ø)
...nal/definitions/definition_handler_network_node.go 100.00% <100.00%> (ø)
...rnal/definitions/definition_handler_network_org.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3992b8...dab9901. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The architecture seemed to work well for all the cases, and be clear to read.

@peterbroadhurst peterbroadhurst merged commit 0b20eb6 into hyperledger:main Feb 4, 2022
@peterbroadhurst peterbroadhurst deleted the finalize branch February 4, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants