Address some inconsistencies in Operation behavior #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awrichar
commented
Feb 4, 2022
awrichar
commented
- Operations should all correspond to an external plugin action (only announce_pool needed a change)
- Name all operations as "plugin_action" (only contract_invoke needed a change)
- Mark operations successful after the new synchronous forms of token pool creation and activation
The convention for all other operations is to prefix them with the name of
the target plugin ("blockchain" in this case).
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
The pool announcement is a definition broadcast and does not need to be tracked by an operation (as it is sufficiently tracked by the pending/confirmed status of the token pool and the pending/confirmed status of its linked message). Pool activation, on the other hand, is an asynchronous operation to an external connector, and does require an operation to track. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 266 266
Lines 15134 15128 -6
==========================================
- Hits 15123 15117 -6
Misses 11 11
Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Feb 4, 2022
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
... reminds me we really need to get the reference section filled in with a bunch of the work you're doing, before V1.0
Contributor
Author
|
Yea - this was a direct result of attempting to make a concise picture of what operations mean, and seeing that a few things didn't line up. It feels very clean now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.