Skip to content

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Feb 5, 2022

Only "message_rejected" will be emitted for rejected definition messages -
no special per-type event will be emitted.

This requires one extra lookup in syncasync to find rejected token pools,
but seems better for overall consistency.

Only "message_rejected" will be emitted for rejected definition messages -
no special per-type event will be emitted.

This requires one extra lookup in syncasync to find rejected token pools,
but seems better for overall consistency.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #482 (23fbf61) into main (83c265f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          266       266           
  Lines        15154     15147    -7     
=========================================
- Hits         15154     15147    -7     
Impacted Files Coverage Δ
pkg/fftypes/event.go 100.00% <ø> (ø)
...ternal/definitions/definition_handler_contracts.go 100.00% <100.00%> (ø)
...ternal/definitions/definition_handler_tokenpool.go 100.00% <100.00%> (ø)
internal/syncasync/sync_async_bridge.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c265f...23fbf61. Read the comment docs.

@awrichar
Copy link
Contributor Author

awrichar commented Feb 7, 2022

Note that this change was prompted after drawing this picture of events:

FireFly_contributor_whiteboarding_-_public_access__Online_Whiteboard_for_Visual_Collaboration

@peterbroadhurst peterbroadhurst merged commit aeff8a8 into hyperledger:main Feb 7, 2022
@peterbroadhurst peterbroadhurst deleted the rejected branch February 7, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants