Skip to content

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Feb 8, 2022

Ensure the operations for tokens and custom contracts behave as expected in success/failure scenarios.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #498 (01e00fa) into main (cf27fa9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #498   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          267       267           
  Lines        15251     15266   +15     
=========================================
+ Hits         15251     15266   +15     
Impacted Files Coverage Δ
internal/assets/token_pool.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)
internal/contracts/manager.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/operation_sql.go 100.00% <100.00%> (ø)
internal/events/dx_callbacks.go 100.00% <100.00%> (ø)
internal/events/operation_update.go 100.00% <100.00%> (ø)
internal/events/token_pool_created.go 100.00% <100.00%> (ø)
internal/txcommon/txcommon.go 100.00% <100.00%> (ø)
pkg/fftypes/operation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf27fa9...01e00fa. Read the comment docs.

@awrichar awrichar changed the title Mark activate_pool operations as successful Misc fixes for operations Feb 9, 2022
This is now only used internally within plugins.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Provides a more compact syntax and better type checking.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterbroadhurst peterbroadhurst merged commit 60e00ff into hyperledger:main Feb 11, 2022
@peterbroadhurst peterbroadhurst deleted the ops branch February 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants