Move insert of events to a special pre-commit phase of the DB transaction #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
reviewed
Feb 11, 2022
|
|
||
| func (bp *batchProcessor) markMessagesDispatched(batch *fftypes.Batch) error { | ||
| return bp.retry.Do(bp.ctx, "batch persist", func(attempt int) (retry bool, err error) { | ||
| return bp.retry.Do(bp.ctx, "mark dispatched messages", func(attempt int) (retry bool, err error) { |
awrichar
reviewed
Feb 11, 2022
| // We choose (today) to coordinate the emission of these, into a DB transaction where the other | ||
| // state changes happen - so the event is assured atomically to happen "after" the other state | ||
| // changes, but also not to be lost. Downstream fan-out of those events occurs via | ||
| // Wehook/WebSocket (.../NATS/Kafka) pluggable pub/sub interfaces. |
Contributor
There was a problem hiding this comment.
Wehook sounds like a web3 fishing conglomerate
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the A->B, B->A deadlock due to differently ordered database operations with the new table lock, seen under a high concurrency performance test in #493 (comment)