Flatten the DXInfo back to the orginal payload on the ffdx API to connectors #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct to connectors Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 275 275
Lines 15788 15793 +5
=========================================
+ Hits 15788 15793 +5
Continue to review full report at Codecov.
|
gabriel-indik
approved these changes
Feb 11, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
awrichar
approved these changes
Feb 12, 2022
Contributor
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Approved, but looks like there are potential build and/or coverage issues
Contributor
Author
|
Taking a look - I tried to address an intermittent coverage issue that doesn't show up locally - looking like I hit something else in the process |
Contributor
Author
|
Raising issue for unrelated UT failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... details in the comments of the change