Build a predictable response body for async "InvokeContract" calls #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of proxying the response from ethconnect/fabconnect, successful "InvokeContract" calls can return a predictable response body constructed by the Contract Manager. The request ID (which is actually the FireFly operation ID) was the only interesting thing returned in the first place, so starting with just that in the new response body. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 275 275
Lines 15812 15809 -3
=========================================
- Hits 15812 15809 -3
Continue to review full report at Codecov.
|
nguyer
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of proxying the response from ethconnect/fabconnect, successful
"InvokeContract" calls can return a predictable response body constructed
by the Contract Manager.
The request ID (which is actually the FireFly operation ID) was the only
interesting thing returned in the first place, so starting with just that
in the new response body.