-
Notifications
You must be signed in to change notification settings - Fork 242
[charts-by-type] histogram broken down by type #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Echelberger <eberger727@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #547 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 303 303
Lines 17389 17424 +35
===========================================
+ Hits 17389 17422 +33
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Signed-off-by: David Echelberger <eberger727@gmail.com>
awrichar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be sure I understand - now all histogram queries will now be broken down by type (to readily support a "stacked bar" type of chart) and there is no way to perform the previous simpler query that just gave totals for each time slice - right?
I think this is fine as long as it supports everything we currently want to do on the firefly-ui.
Signed-off-by: David Echelberger <eberger727@gmail.com>
|
New Payload format to be compatible with current ui [
{
"count": "38",
"timestamp": "2022-03-04T21:42:39Z",
"types": [
{ "count": "13", "type": "transaction_submitted" },
{ "count": "8", "type": "blockchain_event_received" },
{ "count": "0", "type": "identity_confirmed" },
{ "count": "14", "type": "message_confirmed" },
{ "count": "1", "type": "token_pool_confirmed" },
{ "count": "2", "type": "token_transfer_op_failed" }
]
},
{
"count": "0",
"timestamp": "2022-03-04T21:43:19Z",
"types": [
{ "count": "0", "type": "transaction_submitted" },
{ "count": "0", "type": "blockchain_event_received" },
{ "count": "0", "type": "identity_confirmed" },
{ "count": "0", "type": "message_confirmed" },
{ "count": "0", "type": "token_pool_confirmed" },
{ "count": "0", "type": "token_transfer_op_failed" }
]
},
{
"count": "29",
"timestamp": "2022-03-04T21:43:59Z",
"types": [
{ "count": "11", "type": "transaction_submitted" },
{ "count": "6", "type": "blockchain_event_received" },
{ "count": "0", "type": "identity_confirmed" },
{ "count": "9", "type": "message_confirmed" },
{ "count": "1", "type": "token_pool_confirmed" },
{ "count": "2", "type": "token_transfer_op_failed" }
]
}
] |
#546
Support for histogram buckets that are grouped by
typeExample Response:
[ { "buckets": [ { "timestamp": "2022-02-23T22:40:33Z", "count": "23" }, { "timestamp": "2022-02-23T22:45:33Z", "count": "0" }, { "timestamp": "2022-02-23T22:50:33Z", "count": "14" } ], "type": "transaction_submitted" }, { "buckets": [ { "timestamp": "2022-02-23T22:40:33Z", "count": "16" }, { "timestamp": "2022-02-23T22:45:33Z", "count": "0" }, { "timestamp": "2022-02-23T22:50:33Z", "count": "14" } ], "type": "blockchain_event" }, { "buckets": [ { "timestamp": "2022-02-23T22:40:33Z", "count": "22" }, { "timestamp": "2022-02-23T22:45:33Z", "count": "0" }, { "timestamp": "2022-02-23T22:50:33Z", "count": "11" } ], "type": "message_confirmed" }, { "buckets": [ { "timestamp": "2022-02-23T22:40:33Z", "count": "1" }, { "timestamp": "2022-02-23T22:45:33Z", "count": "0" }, { "timestamp": "2022-02-23T22:50:33Z", "count": "1" } ], "type": "token_pool_confirmed" }, { "buckets": [ { "timestamp": "2022-02-23T22:40:33Z", "count": "6" }, { "timestamp": "2022-02-23T22:45:33Z", "count": "0" }, { "timestamp": "2022-02-23T22:50:33Z", "count": "4" } ], "type": "token_transfer_confirmed" } ]