Skip to content

Conversation

@shorsher
Copy link
Member

@shorsher shorsher commented Mar 6, 2022

fetchreferences will add the referred object to the GET /events response

closes #580

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #587 (7a46df5) into main (2044861) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #587   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          304       304           
  Lines        17530     17544   +14     
=========================================
+ Hits         17530     17544   +14     
Impacted Files Coverage Δ
internal/apiserver/route_get_events.go 100.00% <100.00%> (ø)
internal/orchestrator/data_query.go 100.00% <100.00%> (ø)
internal/orchestrator/orchestrator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2044861...7a46df5. Read the comment docs.

@shorsher shorsher changed the title add fetchreferences param to event api add fetchreferences param to events api Mar 7, 2022
@shorsher shorsher marked this pull request as draft March 9, 2022 04:17
`fetchreferences` will add the referred object to the GET /events response

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher force-pushed the api-event-enrichment branch from 9b865f7 to 7a46df5 Compare March 9, 2022 16:15
@shorsher shorsher marked this pull request as ready for review March 9, 2022 16:16
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📤 📨 🧧

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher merged commit d515f26 into hyperledger:main Mar 9, 2022
@shorsher shorsher deleted the api-event-enrichment branch March 9, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add event enrichment to Events API

3 participants