Switch from https to ffdx

[gabriel-indik]

Signed-off-by: Gabriel Indik gabriel.indik@kaleido.io

[gabriel-indik]

Important: hyperledger/firefly-cli#156 should be merged before this change.

[codecov-commenter]

Codecov Report

Merging #590 (8772cc6) into main (00fda51) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #590   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          303       303           
  Lines        17437     17437           
=========================================
  Hits         17437     17437           

Impacted Files	Coverage Δ
internal/config/config.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fda51...8772cc6. Read the comment docs.

[peterbroadhurst]

The fact the E2E is failing without hyperledger/firefly-cli#156 merging might mean we need a tweak to the migration code in FireFly:

firefly/internal/dataexchange/dxfactory/factory.go

Lines 32 to 42 in 00fda51

	func InitPrefix(prefix config.Prefix) {
	for name, plugin := range pluginsByName {
	plugin().InitPrefix(prefix.SubPrefix(name))
	// Migration path for old plugin name
	// TODO: remove this
	if name == "ffdx" {
	plugin().InitPrefix(prefix.SubPrefix("https"))
	}
	}
	}

[gabriel-indik]

Closing based on the observations in hyperledger/firefly-cli#156 (comment)

[peterbroadhurst]

I do believe we need to fix this default @gabriel-indik, so I've done some work to fix the migration to:

1. Cover the case of https.url being set, with ffdx.url not being set
2. Avoid initializing the prefix on the default paths, so that things like ff config do not show the outdated prefix

deferring to @nguyer for review