Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

Note this is in a PR chain with #582

@peterbroadhurst peterbroadhurst marked this pull request as draft March 10, 2022 05:14
@peterbroadhurst peterbroadhurst marked this pull request as ready for review March 10, 2022 13:33
Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will need a merge from main after pre-requisites go in. Left a few notes inline for consideration.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #592 (68038c2) into main (be62be6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #592    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          304       305     +1     
  Lines        17801     17983   +182     
==========================================
+ Hits         17801     17983   +182     
Impacted Files Coverage Δ
internal/assets/token_transfer.go 100.00% <100.00%> (ø)
internal/broadcast/definition.go 100.00% <100.00%> (ø)
internal/broadcast/manager.go 100.00% <100.00%> (ø)
internal/broadcast/message.go 100.00% <100.00%> (ø)
internal/config/config.go 100.00% <100.00%> (ø)
internal/data/data_manager.go 100.00% <100.00%> (ø)
internal/data/message_writer.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/data_sql.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/message_sql.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/provider.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be62be6...68038c2. Read the comment docs.

@peterbroadhurst peterbroadhurst merged commit 491c272 into hyperledger:main Mar 11, 2022
@peterbroadhurst peterbroadhurst deleted the message-writer branch March 11, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants