Add "info" field to token pools, consume "symbol" from connectors #606
Conversation
Can store contract-specific data that does not map to a top-level token pool field - such as the contract address, name, etc. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
If an input "symbol" was specified, the returned one must match. If no input "symbol" was specified, the connector may specify anything. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
changed the title
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #606 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 305 305
Lines 18181 18196 +15
===========================================
+ Hits 18181 18193 +12
- Misses 0 2 +2
- Partials 0 1 +1
Continue to review full report at Codecov.
|
| if ffPool.Symbol == "" { | ||
| ffPool.Symbol = pluginPool.Symbol | ||
| } else if ffPool.Symbol != pluginPool.Symbol { | ||
| return fmt.Errorf("received symbol '%s' does not match requested '%s'", pluginPool.Symbol, ffPool.Symbol) |
There was a problem hiding this comment.
Since this is returned (and probably bubbled up to the user), should this be in the translations file? Also, maybe some wording that indicates that what was actually on the blockchain didn't match the API request. Rather than "received" vs "requested"?
There was a problem hiding this comment.
All the processing in the events module is asynchronous on the event loop, so won't be easily visible to a user except in logs. I can tweak the wording though.
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
3 participants
No description provided.