Push namespace info to token connector, handle batch events #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
If namespace is included in token events, honor it as a way to filter which listener should receive the event (but continue to fan out to all listeners if namespace is omitted). Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.02%
==========================================
Files 300 300
Lines 19655 19687 +32
==========================================
+ Hits 19649 19679 +30
- Misses 5 6 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
nguyer
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in a PR chain with the (massive) #855, so that should be reviewed and merged first. Only the last 2 commits are new.Part of FIR-12
This is the counterpart to hyperledger/firefly-tokens-erc1155#78 and hyperledger/firefly-tokens-erc20-erc721#59.