Move event plugin init to namespace manager #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
commented
Jun 15, 2022
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
peterbroadhurst
approved these changes
Jun 21, 2022
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
Rename of listener to handler for the callbacks makes sense.
Moving towards a situation where plugins have a separate handler registered for each namespace, and they are responsible for maintaining a map makes sense.
Thanks for on validating my understanding that this PR is one step on the journey (for the Events plugin) to a world where the following architecture is true for all plugins:
- plugins are singletons and may serve many namespaces
- orchestrators and managers are one-per-namespace
- callback handlers are one-per-namespace, so when they are registered ideally the plugin can be told exactly one namespace that they will service, so it delivers only those events
Future work will address this on DX/Shared storage etc. (once the kinks are worked out in that on the connector side for DX in particular)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of FIR-12
The event plugins should be singletons, but subscription manager is initialized once per namespace. A single websocket connection may facilitate listeners to multiple subscriptions (and therefore multiple namespaces), and the events need to be delivered to the correct subscription manager.