-
Notifications
You must be signed in to change notification settings - Fork 242
Create firefly contract subscription per namespace #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59229b1 to
ae731eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 299 300 +1
Lines 19481 19508 +27
=======================================
+ Hits 19475 19502 +27
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
ae731eb to
12ef9f8
Compare
|
Note: I was not sure if I needed to make changes to the |
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Update the eth plugin tests to accomodate the changes for subscriptions per namespace Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
- added tests for multiparty manager Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
- additional code comments in blockchain plugin implementations - updated config descriptions Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
We've settled on a predictable structure for `Info`, so putting these fields in a well-defined struct. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
5bdc9d6 to
b9a27b6
Compare
- added handling for all existing subscription names - added improved logging to inform users to upgrade subscriptions - added namespaced subscription names to fabric Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
b9a27b6 to
3d8ba8e
Compare
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
fbf0993 to
5341f8d
Compare
Each namespace now has a unique firefly contract subscription
To support a subscription per namespace, the
fireflyContractconfig section has been replaced with thecontractsarray section under themultipartyconfig.Example:
firstEventis replacingfromBlock, supporting values of newest or oldestThis PR also introduces a new component, multiparty manager, that is responsible for managing the active firefly contract and interfacing with the blockchain plugin on behalf of that contract.
The subscription names will now also contain the name of the namespace it's associated with:
namespaceName_abiName_instanceUniqueHashnamespaceName_event