Move FFI/ABI conversion code to signer and common #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Contributor
|
Release up for firefly-signer to pull in here: https://github.com/hyperledger/firefly-signer/releases/tag/v0.9.11 |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
peterbroadhurst
approved these changes
Jul 7, 2022
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
👍 - thanks for this - great to see a -2.2k drop in code lines, moved over to common (particularly like the code moving out of ethereum.go)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves FFI related things out of core and into shared libraries so they can be used by other FireFly subprojects. Generic FFI types and validations have been moved to
firefly-common. Ethereum specific FFI code has moved tofirefly-signer.Prerequisites for merge:
hyperledger/firefly-common#19
hyperledger/firefly-signer#9
TODO:
go.modafter release offirefly-commonandfirefly-signer