Skip to content

Conversation

@awrichar
Copy link
Contributor

Fixes #871

Also enhance all E2E test suites to check for stuck operations, as this seems to be a recurring theme that slips through the cracks.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #872 (7998c86) into main (7a340a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7998c86 differs from pull request most recent head 63e4da9. Consider uploading reports for the commit 63e4da9 to get more accurate results

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   99.96%   99.97%   +0.01%     
==========================================
  Files         299      299              
  Lines       19481    19483       +2     
==========================================
+ Hits        19475    19479       +4     
+ Misses          5        4       -1     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
internal/dataexchange/ffdx/dxevent.go 100.00% <100.00%> (ø)
internal/tokens/fftokens/fftokens.go 100.00% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a340a9...63e4da9. Read the comment docs.

@awrichar
Copy link
Contributor Author

Looks like for the unpinned message case, the message may get marked "confirmed" before the data exchange operation has recorded success. I assume it's due to operation updates being handle by a separate processing loop. I'm not sure of the best way to handle this... perhaps polling or listening to database change events...

awrichar added 2 commits June 21, 2022 12:01
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Fixes hyperledger#871

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Operations are updated by a separate processing loop in core, and may take
a moment to get marked as successful after completion.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit 45127ca into hyperledger:main Jun 22, 2022
@awrichar awrichar deleted the operations branch June 22, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All DX operations get stuck in pending state

3 participants