Handle namespace validation at the route level rather than at data manager #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the data manager is now instantiated inside a namespace, it's redundant to check if that namespace exists. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Since most routes now query an orchestrator from namespace manager, they should return 404 if an orchestrator can't be found (ie if namespace does not exist). Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
==========================================
+ Coverage 99.95% 99.97% +0.02%
==========================================
Files 300 300
Lines 19479 19457 -22
==========================================
- Hits 19470 19453 -17
+ Misses 7 4 -3
+ Partials 2 0 -2
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
reviewed
Jun 23, 2022
shorsher
approved these changes
Jun 23, 2022
Member
shorsher
left a comment
shorsher
left a comment
There was a problem hiding this comment.
Looks good to me, with a very minor style comment
🚀
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data manager is already part of a namespace, so determination of whether the namespace is valid needs to happen earlier in the router, when we're attempting to lookup the proper orchestrator to handle the request.