Skip to content

Conversation

@awrichar
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Member

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We spoke offline about moving the SubmitNetworkAction logic from orchestrator into multiparty, but I'll leave that with you.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #880 (14159a2) into main (6e6c3f1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 14159a2 differs from pull request most recent head 714855c. Consider uploading reports for the commit 714855c to get more accurate results

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   99.96%   99.97%   +0.01%     
==========================================
  Files         300      299       -1     
  Lines       19450    19466      +16     
==========================================
+ Hits        19444    19462      +18     
+ Misses          5        4       -1     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
internal/broadcast/manager.go 100.00% <100.00%> (ø)
internal/multiparty/manager.go 100.00% <100.00%> (ø)
internal/multiparty/operations.go 100.00% <100.00%> (ø)
internal/orchestrator/orchestrator.go 100.00% <100.00%> (ø)
internal/privatemessaging/privatemessaging.go 100.00% <100.00%> (ø)
internal/events/dx_callbacks.go 100.00% <0.00%> (ø)
internal/dataexchange/ffdx/ffdx.go 100.00% <0.00%> (ø)
internal/dataexchange/ffdx/dxevent.go 100.00% <0.00%> (ø)
internal/database/sqlcommon/sqlcommon.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6c3f1...714855c. Read the comment docs.

@awrichar
Copy link
Contributor Author

Thanks - after a quick look, moving SubmitNetworkAction down will introduce an import cycle between multiparty and identity... so while I think it's correct to do, I'm going to come back to it later.

awrichar added 2 commits June 24, 2022 13:23
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit 190855f into hyperledger:main Jun 24, 2022
@awrichar awrichar deleted the multiparty branch June 24, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants