Custom contract subscriptions now utilize namespaces #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new ethconnect subscriptions now have namespace in the sub name - sub name format is: `ff-sub-<namespace>-<listener ID> If a namespace is in the subscription name, now that event will only be passed to the handler for that namespace. If not, all handlers will be passed the event. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
- new fabconnect subscriptions now have namespace in the sub name - sub name format is: `ff-sub-<namespace>-<listener ID> If a namespace is in the subscription name, now that event will only be passed to the handler for that namespace. If not, all handlers will be passed the event. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
requested review from
awrichar,
nguyer,
nickgaski and
peterbroadhurst
as code owners
awrichar
reviewed
Jul 8, 2022
awrichar
reviewed
Jul 8, 2022
awrichar
reviewed
Jul 8, 2022
awrichar
reviewed
Jul 8, 2022
awrichar
approved these changes
Jul 8, 2022
Contributor
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Looks good - couple of minor comments for you to check over before merge.
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, both ethconnect and fabconnect subscription names contain the namespace name. This means that events will now be delivered only to the callback handler for that namespace, instead of every single callback handler. Older subscriptions will still be delivered to all handlers.