Add basic auth support #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
nguyer
requested review from
awrichar,
nickgaski,
peterbroadhurst and
shorsher
as code owners
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 298 298
Lines 19255 19405 +150
========================================
+ Hits 19249 19399 +150
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
awrichar
reviewed
Jul 12, 2022
| return plugins, err | ||
| } | ||
|
|
||
| func (nm *namespaceManager) Authorize(ctx context.Context, authReq *fftypes.AuthReq) error { |
Contributor
There was a problem hiding this comment.
Who calls this? I see that the routes in the apiserver also call directly to orchestrator.
Contributor
There was a problem hiding this comment.
Oh looks like websocketConnection calls here.
awrichar
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic auth support for:
startrequests over an open WebSocket connectionExample config:
Where
passwordfile: /etc/firefly/allowed_usersis a file created withhtpasswdusing bcrypt hashed passwords. For example, you can create such a file by running:Prerequisites for merge: