[feature] #3525: Standardize transaction API#3485
Merged
mversic merged 1 commit intohyperledger-iroha:iroha2-devfrom Jun 9, 2023
Merged
[feature] #3525: Standardize transaction API#3485mversic merged 1 commit intohyperledger-iroha:iroha2-devfrom
mversic merged 1 commit intohyperledger-iroha:iroha2-devfrom
Conversation
577ade0 to
2c54e2f
Compare
151bb56 to
77f16b8
Compare
74bacc3 to
e97bd46
Compare
Erigara
reviewed
May 25, 2023
d54bdfd to
d4567e2
Compare
Erigara
reviewed
May 26, 2023
d977393 to
c34d62c
Compare
Erigara
reviewed
May 26, 2023
Pull Request Test Coverage Report for Build 5122726761
💛 - Coveralls |
0x009922
reviewed
May 30, 2023
Contributor
0x009922
left a comment
There was a problem hiding this comment.
LGTM, although I don't understand most of the changes.
Erigara
previously approved these changes
May 31, 2023
Contributor
Erigara
left a comment
There was a problem hiding this comment.
LGTM, couple of small comments
Erigara
previously approved these changes
Jun 1, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
appetrosyan
reviewed
Jun 4, 2023
Erigara
reviewed
Jun 6, 2023
Erigara
previously approved these changes
Jun 6, 2023
This was referenced Jun 9, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan
approved these changes
Jun 9, 2023
Erigara
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rules:
*Boxin the client code or integration tests.These structs exist only for serialization. If you write this type explicitly, this is a smell and user facing API should be updated.
V1in any crate exceptdata_modelor in tests in other crates.Ideally, any versioned struct(I mean
SignedTransactionshould be private, notVersionedSignedTransaction) should not be accessible from outside code. This isn't possible atm because of some tests. We want the code incore/clientto be version agnosticdata_modeland it should be the 1st in the lifecycleexcept for the first, all other state transitions are internal and must not be exposed through
data_model. This also means thatVersionedCommittedBlockshould be replaced withVersionedSignedBlock. This will be addressed in the next PRLinked issue
Closes #3525
Benefits
Checklist
CONTRIBUTING.md