Skip to content

Incorporate additional Protocol Buffers (protobuf) parameters to enhance the extensibility and functionality of the data model within the specified oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information.#3840

Closed
dominious1 wants to merge 2 commits intohyperledger-iroha:mainfrom
dominious1:main

Conversation

@dominious1
Copy link
Copy Markdown
Contributor

@dominious1 dominious1 commented Aug 27, 2023

Integrate optional parameters: 'description,' 'destinationAccount,' and 'sourceAccount.'

Facilitate the search for transactions by incorporating the capability to include multiple text fragments in the query. This feature proves particularly useful when seeking transactions within a banking context, where specific keywords are employed with an uncertain sequence. Additionally, enable the retrieval of all transactions directed to a designated account and those originating from a specified account.

@baziorek
Copy link
Copy Markdown
Contributor

It is implementation of an internship project: https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments

@dominious1 Please add more description and make the PR as draft pull request for now.

Comment on lines +34 to +36
std::optional<interface::types::HeightType> transText() const override;
std::optional<interface::types::HeightType> transAccount() const override;
std::optional<interface::types::HeightType> transSentFromAccount()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest shorter names as used in rest of code: transaction -> tx, so:

Suggested change
std::optional<interface::types::HeightType> transText() const override;
std::optional<interface::types::HeightType> transAccount() const override;
std::optional<interface::types::HeightType> transSentFromAccount()
std::optional<interface::types::HeightType> txText() const override;
std::optional<interface::types::HeightType> txAccount() const override;
std::optional<interface::types::HeightType> txSentFromAccount()

In other places also change into tx

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the word trans can confuse users. It's not just about brevity.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

@andprogrammer
Copy link
Copy Markdown
Contributor

Please remember about adding --signoff flag once you commit any new change. Example:
git commit --signoff --message "Test msg"

@andprogrammer
Copy link
Copy Markdown
Contributor

Please be more specific in the PR's description. You can add few more lines from here
https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments

@baziorek baziorek added good first issue Good for newcomers 1.x api-changes Changes in the API for client libraries 1.5 queries labels Aug 31, 2023
@dominious1 dominious1 changed the title Add new protobuf parameters Incorporate additional Protocol Buffers (protobuf) parameters to enhance the extensibility and functionality of the data model within the specified oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information. Nov 10, 2023
@baziorek
Copy link
Copy Markdown
Contributor

@dominious1 I think that the PR can be closed. So I'm closing its. If You have time and want to do its after completing: #4003 we can reopen:)

@baziorek baziorek closed this Jan 15, 2024
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.x 1.5 api-changes Changes in the API for client libraries good first issue Good for newcomers iroha1 The legacy version of Iroha. queries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants