Incorporate additional Protocol Buffers (protobuf) parameters to enhance the extensibility and functionality of the data model within the specified oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information.#3840
Incorporate additional Protocol Buffers (protobuf) parameters to enhance the extensibility and functionality of the data model within the specified oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information.#3840dominious1 wants to merge 2 commits intohyperledger-iroha:mainfrom
Conversation
|
It is implementation of an internship project: https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments @dominious1 Please add more description and make the PR as draft pull request for now. |
| std::optional<interface::types::HeightType> transText() const override; | ||
| std::optional<interface::types::HeightType> transAccount() const override; | ||
| std::optional<interface::types::HeightType> transSentFromAccount() |
There was a problem hiding this comment.
I suggest shorter names as used in rest of code: transaction -> tx, so:
| std::optional<interface::types::HeightType> transText() const override; | |
| std::optional<interface::types::HeightType> transAccount() const override; | |
| std::optional<interface::types::HeightType> transSentFromAccount() | |
| std::optional<interface::types::HeightType> txText() const override; | |
| std::optional<interface::types::HeightType> txAccount() const override; | |
| std::optional<interface::types::HeightType> txSentFromAccount() |
In other places also change into tx
There was a problem hiding this comment.
Also the word trans can confuse users. It's not just about brevity.
|
Please remember about adding --signoff flag once you commit any new change. Example: |
|
Please be more specific in the PR's description. You can add few more lines from here |
|
@dominious1 I think that the PR can be closed. So I'm closing its. If You have time and want to do its after completing: #4003 we can reopen:) |
Integrate optional parameters: 'description,' 'destinationAccount,' and 'sourceAccount.'
Facilitate the search for transactions by incorporating the capability to include multiple text fragments in the query. This feature proves particularly useful when seeking transactions within a banking context, where specific keywords are employed with an uncertain sequence. Additionally, enable the retrieval of all transactions directed to a designated account and those originating from a specified account.