Deduplicate mem mgr and host functions from hv drivers #1013
+83
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
added
kind/enhancement
ludfjig
changed the title
ludfjig
force-pushed
the
dedupe_mem_mgr
branch
from
471c325 to
9dcc7b5
Compare
ludfjig
force-pushed
the
dedupe_mem_mgr
branch
from
9dcc7b5 to
54d5b13
Compare
ludfjig
changed the title
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
dedupe_mem_mgr
branch
from
706402f to
b368621
Compare
ludfjig
changed the title
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
jsturtevant
reviewed
Nov 21, 2025
jsturtevant
previously approved these changes
Nov 21, 2025
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
jsturtevant
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MemoryManager and FunctionRegistry fields from drivers, passing them as parameters instead. This eliminates duplicate ownership since they are already part of the sandbox itself, simplifies the ownership model and gets rid of a complete category of possible errors.
Easiest reviewed commit by commit