Many orders and cancels #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2023 20:51
Signed-off-by: ed <>
Signed-off-by: ed <>
|
Thanks for adding this @elevatordown @traderben is the python SDK expert, will let him take a look |
traderben
reviewed
Jul 12, 2023
Contributor
traderben
left a comment
traderben
left a comment
There was a problem hiding this comment.
Thanks for putting this PR together!
hyperliquid/exchange.py
Outdated
| ) | ||
|
|
||
| def cancel(self, coin: str, oid: int) -> Any: | ||
| def cancel(self, coin: str, oids: List[int]) -> Any: |
Contributor
There was a problem hiding this comment.
I feel similarly that we should have a separate cancels method and that should take a list of coin, oid pairs instead of just a list of oids
added 3 commits
July 13, 2023 08:17
Contributor
Author
|
@traderben addressed all comments |
Contributor
Author
|
havent seen makefiles in like 10 years, made my day |
traderben
reviewed
Jul 13, 2023
Contributor
traderben
left a comment
traderben
left a comment
There was a problem hiding this comment.
Awesome! Thanks for addressing all the comments, just one more small issue
traderben
approved these changes
Jul 14, 2023
perplover
pushed a commit
to perplover/hyperliquid-python-sdk
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.