Skip to content

reference handling insertImportSpec #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

reference handling insertImportSpec #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-crabs-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@codeshift/utils': patch
---

InsertImportSpecifier now retains the reference to the original import declaration
19 changes: 5 additions & 14 deletions packages/utils/src/imports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,18 +122,9 @@ export function insertImportSpecifier(
importSpecifier: ImportSpecifier | ImportDefaultSpecifier,
sourcePath: string,
) {
getImportDeclaration(j, source, sourcePath).replaceWith(declaration =>
j.importDeclaration(
[
// we are appending to the existing specifiers
// We are doing a filter hear because sometimes specifiers can be removed
// but they hang around in the declaration
...(declaration.value.specifiers || []).filter(
item => item.type === 'ImportSpecifier' && item.imported != null,
),
importSpecifier,
],
j.literal(sourcePath),
),
);
const importDeclaration = getImportDeclaration(j, source, sourcePath);

if (!importDeclaration) return;

importDeclaration.get().value.specifiers.push(importSpecifier);
}