Skip to content

remove deprecated DialSlashEndpoint, DialSlashGraphQLEndpoint #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

remove deprecated DialSlashEndpoint, DialSlashGraphQLEndpoint #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,25 +71,6 @@ func NewDgraphClient(clients ...api.DgraphClient) *Dgraph {
return dg
}

// DialSlashEndpoint is deprecated. It will be removed in the 21.07 release.
// Use DialCloud to connect to Dgraph Cloud backend.
func DialSlashEndpoint(endpoint, key string) (*grpc.ClientConn, error) {
return DialCloud(endpoint, key)
}

// DialSlashGraphQLEndpoint is deprecated, as it leaks GRPC connections.
// It will be removed in the 21.07 release. Please use DialCloud instead.
func DialSlashGraphQLEndpoint(endpoint, key string) (*Dgraph, error) {
conn, err := DialCloud(endpoint, key)
if err != nil {
return nil, err
}

dc := api.NewDgraphClient(conn)
dg := NewDgraphClient(dc)
return dg, nil
}

// DialCloud creates a new TLS connection to a Dgraph Cloud backend
//
// It requires the backend endpoint as well as the api token
Expand Down