Conversation
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @codexnull)
worker/export.go, line 73 at r1 (raw file):
// UIDs like 0x1 look weird but 64-bit ones like 0x0000000000000001 are too long. var uidFmtStr = "<0x%x>"
I thought based on the discussion in the issue that this was going to be an option and the default was still going to be blank nodes.
codexnull
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
worker/export.go, line 73 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
I thought based on the discussion in the issue that this was going to be an option and the default was still going to be blank nodes.
Yeah, but during the stand-up @manishrjain said to use the UID.
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull and @martinmr)
dgraph/cmd/live/batch.go, line 140 at r1 (raw file):
time.Sleep(dur) case err != y.ErrAborted && err != y.ErrConflict: fmt.Printf("Error while mutating. %v\n", s.Message())
switch to colon.
worker/export.go, line 73 at r1 (raw file):
Previously, codexnull (Javier Alvarado) wrote…
Yeah, but during the stand-up @manishrjain said to use the UID.
Yup, UID directly for every export.
codexnull
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
dgraph/cmd/live/batch.go, line 140 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
switch to colon.
Done.
* Export with the actual UIDs instead of blanks. * Fix awkwardly punctuated error message. * Fix tests assuming _:uid in export.
Include actual UIDs in export instead of "_:uid" blanks. Fixes #2934.
This change is