Merged
Conversation
The default value logic obseleted this error. When generating the output graph we already have all the values necessary. This error was when we needed to match uidToVal to NeedsVar.
manishrjain
approved these changes
Mar 21, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog)
query/query.go, line 343 at r1 (raw file):
func addInternalNode(pc *SubGraph, uid uint64, dst outputNode) error { if len(pc.Params.uidToVal) == 0 { glog.V(2).Infof("Wrong use of var() with %v.", pc.Params.NeedsVar)
Can just skip the info log as well.
srfrog
commented
Mar 26, 2019
Contributor
Author
srfrog
left a comment
srfrog
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
query/query.go, line 343 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Can just skip the info log as well.
Done.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* query/query.go: turn obsolete error into warning The default value logic obseleted this error. When generating the output graph we already have all the values necessary. This error was when we needed to match uidToVal to NeedsVar. * query/query.go: remove info log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value logic obsoleted this error. When generating the output graph
we already have all the values necessary. This error was when we needed to match
uidToValto
NeedsVar.Closes #3171
This change is